Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pull-kubernetes-e2e-gke-gpu create custom network #4988

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Oct 12, 2017

From #4472 (comment), making pull-kubernetes-e2e-gke-gpu create custom network.

From https://k8s-testgrid.appspot.com/kubernetes-presubmits#pull-kubernetes-e2e-gke-gpu I see empty history. How do I verify it is not failing and who usually triggers this job?

/assign @krzyzacy @mindprince

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2017
jobs/config.json Outdated
@@ -10261,6 +10261,7 @@
"args": [
"--build=bazel",
"--cluster=",
"--env-file=jobs/env/pull-kubernetes-e2e-gke-gpu.env",
Copy link
Member

@krzyzacy krzyzacy Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use --env=CREATE_CUSTOM_NETWORK=true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and preferably this can be a kubetest flag)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to use --env=CREATE_CUSTOM_NETWORK=true for now.

@MrHohn MrHohn force-pushed the pull-kubernetes-e2e-gke-gpu-custom-network branch from 1669f71 to 932095a Compare October 12, 2017 23:22
@krzyzacy
Copy link
Member

keep the args sorted :-)

@MrHohn MrHohn force-pushed the pull-kubernetes-e2e-gke-gpu-custom-network branch from 932095a to 3eb0aaa Compare October 12, 2017 23:48
@MrHohn
Copy link
Member Author

MrHohn commented Oct 12, 2017

keep the args sorted :-)

Oops, fixed now.

@MrHohn
Copy link
Member Author

MrHohn commented Oct 12, 2017

ImportError: No module named setuptools

Humm, is that a flake?

/retest

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, MrHohn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2017
@k8s-ci-robot k8s-ci-robot merged commit d25f86d into kubernetes:master Oct 13, 2017
@BenTheElder
Copy link
Member

From https://k8s-testgrid.appspot.com/kubernetes-presubmits#pull-kubernetes-e2e-gke-gpu I see empty history. How do I verify it is not failing and who usually triggers this job?

I'm not sure who usually triggers it but it is manually triggered which is why the history is empty. The GCE GPU job is used normally AFAIK.

@krzyzacy
Copy link
Member

for presubmit, testgrid only displays one day's history... which means no body triggered the job yesterday :-)

@rohitagarwal003
Copy link
Member

@MrHohn
Copy link
Member Author

MrHohn commented Oct 13, 2017

Thanks folks. Also bad news, just realized that the custom network feature might not work on GKE. We should choose a GCE PR job to start with..

@BenTheElder
Copy link
Member

@MrHohn how about pull-kubernetes-e2e-gce-gpu? :-)

@rohitagarwal003
Copy link
Member

Do GPU jobs have an official guinea pig status now? :-P

@krzyzacy
Copy link
Member

Or we can create a dummy job and then delete it later

@mindprince or we should make gpu job blocking :-)

@MrHohn
Copy link
Member Author

MrHohn commented Oct 13, 2017

Or we can create a dummy job and then delete it later

I've tested the custom network feature on all auto-run PR jobs on kubernetes/kubernetes#52377 for couple times (by temporarily setting CREATE_CUSTOM_NETWORK=true) and they all looked fine. We will be able to gain more confidence if we canary it on an auto-run PR job.

Also vote for pull-kubernetes-e2e-gce-gpu, but let's make the change (or decision) tomorrow morning in case it will break :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants