-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pull-kubernetes-e2e-gke-gpu create custom network #4988
Make pull-kubernetes-e2e-gke-gpu create custom network #4988
Conversation
jobs/config.json
Outdated
@@ -10261,6 +10261,7 @@ | |||
"args": [ | |||
"--build=bazel", | |||
"--cluster=", | |||
"--env-file=jobs/env/pull-kubernetes-e2e-gke-gpu.env", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use --env=CREATE_CUSTOM_NETWORK=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and preferably this can be a kubetest flag)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use --env=CREATE_CUSTOM_NETWORK=true
for now.
1669f71
to
932095a
Compare
keep the args sorted :-) |
932095a
to
3eb0aaa
Compare
Oops, fixed now. |
Humm, is that a flake? /retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, MrHohn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
I'm not sure who usually triggers it but it is manually triggered which is why the history is empty. The GCE GPU job is used normally AFAIK. |
for presubmit, testgrid only displays one day's history... which means no body triggered the job yesterday :-) |
Here's the history for the job: https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gke-gpu |
Thanks folks. Also bad news, just realized that the custom network feature might not work on GKE. We should choose a GCE PR job to start with.. |
@MrHohn how about pull-kubernetes-e2e-gce-gpu? :-) |
Do GPU jobs have an official guinea pig status now? :-P |
Or we can create a dummy job and then delete it later @mindprince or we should make gpu job blocking :-) |
I've tested the custom network feature on all auto-run PR jobs on kubernetes/kubernetes#52377 for couple times (by temporarily setting Also vote for |
From #4472 (comment), making
pull-kubernetes-e2e-gke-gpu
create custom network.From https://k8s-testgrid.appspot.com/kubernetes-presubmits#pull-kubernetes-e2e-gke-gpu I see empty history. How do I verify it is not failing and who usually triggers this job?
/assign @krzyzacy @mindprince